Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47095 )
Change subject: sb/intel/lynxpoint: Use common AHCI library ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... File src/southbridge/intel/lynxpoint/sata.c:
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... PS2, Line 116: /* Should be configurable */
clarification: I'll update the comment, but I don't think I'll implement this in the foreseeable fut […]
Done
https://review.coreboot.org/c/coreboot/+/47095/2/src/southbridge/intel/lynxp... PS2, Line 141: ahci_cap_2.supports_device_sleep = 1;
why?
FWIW, the order logic here is the ordering in the bitfield definition