Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39027 )
Change subject: soc/mediatek: Fix typos in comments
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39027/1/src/soc/mediatek/mt8173/emi...
File src/soc/mediatek/mt8173/emi.c:
https://review.coreboot.org/c/coreboot/+/39027/1/src/soc/mediatek/mt8173/emi...
PS1, Line 162: transfer
so we divide by 8 ?
kind of, it's: 2^(bit_counter-3) = 2^bit_counter / 2^3 = 2^bit_counter / 8
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39027
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3361122d5232072e68d018e84219a262acf34001
Gerrit-Change-Number: 39027
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Jacob Garber
jgarber1@ualberta.ca
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 21 Feb 2020 16:03:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: HAOUAS Elyes
ehaouas@noos.fr
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment