Rex-BC Chen has submitted this change. ( https://review.coreboot.org/c/coreboot/+/74115 )
(
12 is the latest approved patch-set. No files were changed between the latest approved patch-set and the submitted one. )Change subject: mb/google/geralt: Power on Samsung ATNA33XC20 eDP panel ......................................................................
mb/google/geralt: Power on Samsung ATNA33XC20 eDP panel
Geralt uses Samsung panel, and Mutto is responsible for bonding the panel and touch, so rename the panel description. Add power-on sequence for Samsung ATNA33XC20 panel.
EDID Info: header: 00 ff ff ff ff ff ff 00 serial number: 4c 83 62 41 00 00 00 00 28 1e version: 01 04 basic params: b5 1d 11 78 02 chroma info: 0c f1 ae 52 3c b9 23 0c 50 54 established: 00 00 00 standard: 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 01 descriptor 1: 35 36 80 a0 70 38 20 40 30 20 88 00 26 a5 10 00 00 1b descriptor 2: 35 36 80 a0 70 38 20 40 30 20 88 00 26 a5 10 00 00 1b descriptor 3: 00 00 00 0f 00 d1 09 3c d1 09 3c 28 80 00 00 00 00 00 descriptor 4: 00 00 00 fe 00 41 54 4e 41 33 33 58 43 32 30 2d 30 20 extensions: 01 checksum: 6f
BUG=b:276097739 TEST=test firmware display pass.
Signed-off-by: Jianeng Ceng cengjianeng@huaqin.corp-partner.google.com Change-Id: Ibd2d05c7eef1360ca954316f2e76b21ed1f85be8 Reviewed-on: https://review.coreboot.org/c/coreboot/+/74115 Reviewed-by: Rex-BC Chen rex-bc.chen@mediatek.com Reviewed-by: cong yang yangcong5@huaqin.corp-partner.google.com Reviewed-by: Yidi Lin yidilin@google.com Reviewed-by: jason-ch chen Jason-ch.Chen@mediatek.com Reviewed-by: Yu-Ping Wu yupingso@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/google/geralt/panel_geralt.c 1 file changed, 48 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Yu-Ping Wu: Looks good to me, approved Yidi Lin: Looks good to me, but someone else must approve Rex-BC Chen: Looks good to me, but someone else must approve jason-ch chen: Looks good to me, but someone else must approve cong yang: Looks good to me, but someone else must approve
diff --git a/src/mainboard/google/geralt/panel_geralt.c b/src/mainboard/google/geralt/panel_geralt.c index 1cb8e47..159bc76 100644 --- a/src/mainboard/google/geralt/panel_geralt.c +++ b/src/mainboard/google/geralt/panel_geralt.c @@ -22,9 +22,9 @@ gpio_output(GPIO_MIPI_BL_PWM_1V8, 0); }
-static void configure_edp_aux_backlight(void) +static void configure_edp_backlight(void) { - /* TODO: Add edp aux backlight for MUTTO_B152731E1 when we get MUTTO_B152731E1 */ + gpio_output(GPIO_AP_DISP_BKLTEN, 0); }
static void power_on_mipi_boe_tv110c9m_ll0(void) @@ -48,9 +48,11 @@ mdelay(6); }
-static void power_on_edp_mutto_b152731e1(void) +static void power_on_edp_samsung_atana33xc20(void) { - /* TODO: Add the poweron for MUTTO_B152731E1 when we get MUTTO_B152731E1 */ + gpio_output(GPIO_EN_PP3300_EDP_DISP_X, 1); + gpio_set_pull(GPIO_EDP_HPD_1V8, GPIO_PULL_ENABLE, GPIO_PULL_UP); + gpio_set_mode(GPIO_EDP_HPD_1V8, 4); }
static struct panel_description panels[] = { @@ -62,9 +64,9 @@ .pwm_ctrl_gpio = true, }, [11] = { - .name = "MUTTO_B152731E1", - .power_on = power_on_edp_mutto_b152731e1, - .configure_panel_backlight = configure_edp_aux_backlight, + .name = "SAMSUNG_ATANA33XC20", + .power_on = power_on_edp_samsung_atana33xc20, + .configure_panel_backlight = configure_edp_backlight, .disp_path = DISP_PATH_EDP, .pwm_ctrl_gpio = false, },