Attention is currently required from: Jon Murphy, Martin L Roth.
Karthik Ramasubramanian has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/86148?usp=email )
Change subject: util/crossgcc: Add missing printf variable
......................................................................
Patch Set 2:
(1 comment)
File util/crossgcc/buildgcc:
https://review.coreboot.org/c/coreboot/+/86148/comment/3575db22_cae429bd?usp... :
PS2, Line 859: if [[ ! -e ${LIBSTDCXX_INCLUDE_PATH} ]]; then
Please also mention this change in the commit message.
Nit: Please quote this instead of [[ ]] just to be consistent with the rest of the file.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86148?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I195718e43ea842970f5fa986315c9e9f11395362
Gerrit-Change-Number: 86148
Gerrit-PatchSet: 2
Gerrit-Owner: Jon Murphy
jpmurphy@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin L Roth
gaumless@gmail.com
Gerrit-Reviewer: Raul Rangel
rrangel@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Martin L Roth
gaumless@gmail.com
Gerrit-Attention: Jon Murphy
jpmurphy@google.com
Gerrit-Comment-Date: Mon, 27 Jan 2025 16:53:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org