Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37168 )
Change subject: sb/amd/{agesa,pi}/hudson: add southbridge C bootblock initialization ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... PS1, Line 31: : ifeq ($(CONFIG_C_ENVIRONMENT_BOOTBLOCK),y)
Compiler may complain on unused static functions then
Grep for samples of __unused if you encounter such errors.
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... File src/southbridge/amd/pi/hudson/bootblock.c:
https://review.coreboot.org/c/coreboot/+/37168/1/src/southbridge/amd/pi/huds... PS1, Line 64: #if CONFIG(C_ENVIRONMENT_BOOTBLOCK)
Did not want to duplicate the bootblock_southbridge_init code and break boards that do not have C bo […]
Other boards are disabled from build now.
You either create one mammoth commit that changes all the binaryPI boards to C_ENV_BB in one go, or you introduce several transient Kconfig options and probably triple the time of development and review. When we create clean transition with APU2, it's not that hard to repeat the flow on one of the other boards, should some of them survive.
Probably both Pascal and I want preference on VBOOT, not efforts on boards that nobody has tested for several years.