build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47388 )
Change subject: soc/intel/elkhartlake: Adding PSE TSN support & PSE UPDs configs ......................................................................
Patch Set 3:
(10 comments)
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/K... File src/soc/intel/elkhartlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/K... PS3, Line 236: string "TSN MAC adress binary path and filename" 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/K... PS3, Line 239: The path and filename of the TSN mac adress binary. 'adress' may be misspelled - perhaps 'address'?
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... File src/soc/intel/elkhartlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 36: PSE_CONFIG_PSEowned =0x1, spaces required around that '=' (ctx:WxV)
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 104: if (CONFIG(ENABLE_TSN)){ suspect code indent for conditional statements (8, 8)
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 104: if (CONFIG(ENABLE_TSN)){ space required before the open brace '{'
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 107: trailing whitespace
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 109: params->TsnMacAddrBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 113: trailing whitespace
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 114: params->TsnConfigBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations
https://review.coreboot.org/c/coreboot/+/47388/3/src/soc/intel/elkhartlake/f... PS3, Line 119: params->PseTsnIpConfigBase = (uint32_t)cbfs_boot_map_with_leak(\ Avoid unnecessary line continuations