View Change

10 comments:

• File src/soc/intel/elkhartlake/Kconfig:

  • Patch Set #3, Line 236: string "TSN MAC adress binary path and filename"

    'adress' may be misspelled - perhaps 'address'?

  • Patch Set #3, Line 239: The path and filename of the TSN mac adress binary.

    'adress' may be misspelled - perhaps 'address'?

• File src/soc/intel/elkhartlake/fsp_params.c:

  • Patch Set #3, Line 36: PSE_CONFIG_PSEowned =0x1,

    spaces required around that '=' (ctx:WxV)

  • Patch Set #3, Line 104: if (CONFIG(ENABLE_TSN)){

    suspect code indent for conditional statements (8, 8)

  • Patch Set #3, Line 104: if (CONFIG(ENABLE_TSN)){

    space required before the open brace '{'

  • Patch Set #3, Line 107:

    trailing whitespace

  • Patch Set #3, Line 109: params->TsnMacAddrBase = (uint32_t)cbfs_boot_map_with_leak(\

    Avoid unnecessary line continuations

  • Patch Set #3, Line 113:

    trailing whitespace

  • Patch Set #3, Line 114: params->TsnConfigBase = (uint32_t)cbfs_boot_map_with_leak(\

    Avoid unnecessary line continuations

  • Patch Set #3, Line 119: params->PseTsnIpConfigBase = (uint32_t)cbfs_boot_map_with_leak(\

    Avoid unnecessary line continuations

To view, visit change 47388. To unsubscribe, or for help writing mail filters, visit settings.