John Zhao has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42056 )
Change subject: soc/intel/tigerlake: Set FSPS UPD ITbtConnectTopologyTimeoutInMs
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42056/1/src/soc/intel/tigerlake/fsp...
File src/soc/intel/tigerlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/42056/1/src/soc/intel/tigerlake/fsp...
PS1, Line 117: Set
set, as in disable CNTP entirely?
CNTP is supposed to be skipped for SW CM. Set this UPD value 0 to avoid ~10 seconds delay now though current FSP v3197 still sends CNTP. Future release FSP will evaluate this UPD and will not send CNTP while finding the UPD value being 0. There will also be no ~10 seconds delay at boot.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42056
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I47e3519fd818cb56e6abd16464d8370ffddabc5b
Gerrit-Change-Number: 42056
Gerrit-PatchSet: 2
Gerrit-Owner: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Divya S Sasidharan
divya.s.sasidharan@intel.com
Gerrit-Reviewer: Divya Sasidharan
divya.s.sasidharan@intel.corp-partner.google.com
Gerrit-Reviewer: John Zhao
john.zhao@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Prashant Malani
pmalani@google.com
Gerrit-Reviewer: Shamile Khan
shamile.khan@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 05 Jun 2020 23:27:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Caveh Jalali
caveh@chromium.org
Gerrit-MessageType: comment