Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39430 )
Change subject: edid_fill_fb: Add row_alignment argument ......................................................................
Patch Set 10: Code-Review-1
(3 comments)
Sorry for not looking earlier into this. I don't understand it.
What does it fix? What does it provide?
All I see is a positive diffstat (comlexitiy added?), and a working, generic concept (bytes_per_line) replaced by a broken, abstract one that doesn't always apply (bytes_per_line can be arbitrary so far, there is no power-of-2 alignment rule).
(ignore the left-unitialized comments, those are fixed in the next change)
https://review.coreboot.org/c/coreboot/+/39430/10/src/mainboard/emulation/qe... File src/mainboard/emulation/qemu-armv7/mainboard.c:
https://review.coreboot.org/c/coreboot/+/39430/10/src/mainboard/emulation/qe... PS10, Line 15: struct edid edid; Left uninitialized?
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra124/di... File src/soc/nvidia/tegra124/display.c:
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra124/di... PS10, Line 315: struct edid edid; Left uninitialized?
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra210/dc... File src/soc/nvidia/tegra210/dc.c:
https://review.coreboot.org/c/coreboot/+/39430/10/src/soc/nvidia/tegra210/dc... PS10, Line 216: struct edid edid; Left uninitialized?