17 Mar
2019
17 Mar
'19
3:24 a.m.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31943 )
Change subject: vboot: deprecate physical dev switch ......................................................................
Patch Set 1:
(2 comments)
I don't know the details, I thought virtual dev switch depended on chrome-ec.
https://review.coreboot.org/#/c/31943/1/src/mainboard/samsung/stumpy/chromeo... File src/mainboard/samsung/stumpy/chromeos.c:
https://review.coreboot.org/#/c/31943/1/src/mainboard/samsung/stumpy/chromeo... PS1, Line 132: Do you want to keep this?
https://review.coreboot.org/#/c/31943/1/src/mainboard/samsung/stumpy/chromeo... PS1, Line 139: This probably keeps switch advertised in ACPI ?
--
To view, visit https://review.coreboot.org/c/coreboot/+/31943
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I87ec0db6148c1727b95475d94e3e3f6e7ec83193
Gerrit-Change-Number: 31943
Gerrit-PatchSet: 1
Gerrit-Owner: Joel Kitching kitching@google.com
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Joel Kitching kitching@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Sun, 17 Mar 2019 10:24:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment