Attention is currently required from: Václav Straka.
Angel Pons has posted comments on this change by Václav Straka. ( https://review.coreboot.org/c/coreboot/+/85825?usp=email )
The change is no longer submittable: All-Comments-Resolved is unsatisfied now.
Change subject: mb/hp: Add Pro 3400 ......................................................................
Patch Set 11: Code-Review+1
(4 comments)
File Documentation/mainboard/hp/pro_3500_series.md:
https://review.coreboot.org/c/coreboot/+/85825/comment/b62934de_f8708df8?usp... : PS11, Line 51: (although it reports as : "N25Q064..3E", it works fine). : That probably means some mainboards used non-Winbond flash chips, which is quite common (BOM variations). AIUI, this is to have a backup plan in case a certain chip is not available (or too expensive) for some reason.
File src/mainboard/hp/pro_3x00_series/Kconfig:
https://review.coreboot.org/c/coreboot/+/85825/comment/7a6b83ed_04c8f2ed?usp... : PS11, Line 46: config DRAM_RESET_GATE_GPIO : default 60 That's the default and could be removed
File src/mainboard/hp/pro_3x00_series/variants/pro_3400_series/board_info.txt:
https://review.coreboot.org/c/coreboot/+/85825/comment/0474c603_9178e0d8?usp... : PS11, Line 2: ROM IC: W25Q32BVSIG I wouldn't list the chip model, not all boards have the same chip model
File src/mainboard/hp/pro_3x00_series/variants/pro_3500_series/board_info.txt:
https://review.coreboot.org/c/coreboot/+/85825/comment/f3c159f6_1dd88af1?usp... : PS11, Line 2: ROM IC: W25Q64FVSIG Same, especially if the docs said something about a different chip model