Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43796 )
Change subject: soc/mediatek/mt8183: Transfer ddr geometry type to dram blob
......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43796/14/src/soc/mediatek/mt8183/me...
File src/soc/mediatek/mt8183/memory.c:
https://review.coreboot.org/c/coreboot/+/43796/14/src/soc/mediatek/mt8183/me...
PS14, Line 116: :
Can we add a space after ":"?
ddr_geometry: %d, config: %#x
https://review.coreboot.org/c/coreboot/+/43796/14/src/soc/mediatek/mt8183/me...
PS14, Line 116: %d
%#x
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3a677195f5036321939c60c8f9f1bace7c4a2e3f
Gerrit-Change-Number: 43796
Gerrit-PatchSet: 14
Gerrit-Owner: Duan huayang
huayang.duan@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Aug 2020 05:56:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment