Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42078 )
Change subject: src/ec/google/chromeec: Get Type-C Mux info from EC (TCPM) ......................................................................
Patch Set 5:
(4 comments)
https://review.coreboot.org/c/coreboot/+/42078/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42078/5//COMMIT_MSG@9 PS5, Line 9: EC being the TCPM decides the mux configuration after : negotiating with the port partner on the Type-C port. The APIs : added here will give the current essential mux state information : for a given port. Please re-flow for 75 characters per line.
https://review.coreboot.org/c/coreboot/+/42078/5/src/ec/google/chromeec/ec.h File src/ec/google/chromeec/ec.h:
https://review.coreboot.org/c/coreboot/+/42078/5/src/ec/google/chromeec/ec.h... PS5, Line 33: * usb capability, dp capability, cable type, etc Please use spaces for alignment.
https://review.coreboot.org/c/coreboot/+/42078/5/src/ec/google/chromeec/ec.h... PS5, Line 30: /* Check for the current mux state in EC : * in: int port physical port number of the type-c port : * out: uint8_t flags flags representing the status of the mux such as : * usb capability, dp capability, cable type, etc : */ https://doc.coreboot.org/coding_style.html#commenting
https://review.coreboot.org/c/coreboot/+/42078/5/src/ec/google/chromeec/ec.h... PS5, Line 325: int google_chromeec_get_num_pd_ports(uint8_t *num_ports); Why is the signature changed? Please stay with the “native” types like `unsigned int` or `size_t`.