Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43766 )
Change subject: security/vboot/Makefile.inc: Update regions-for-file function ......................................................................
Patch Set 5:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43766/5/src/security/vboot/Makefile... File src/security/vboot/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/43766/5/src/security/vboot/Makefile... PS5, Line 174: $(if $(value regions-for-file-$(1)), \ Here's how I think the indentation should look here:
```C regions-for-file = $(subst $(spc),$(comma),$(sort \ $(if $(value regions-for-file-$(1)), \ $(regions-for-file-$(1)), $(if $(filter y,$(CONFIG_VBOOT_STARTS_IN_ROMSTAGE)), \ %/romstage,) \ mts \ %/verstage \ ... ```
The `$(regions-for-file-$(1)), ` is the "then" arm of the if, and the `$(if $(filter y...` is the 'else' arm of the if statement.