Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43278 )
Change subject: mb/google/vilboz: update telemetry settings for vilboz
......................................................................
Patch Set 9: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/43278/9/src/mainboard/google/zork/v...
File src/mainboard/google/zork/variants/vilboz/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/43278/9/src/mainboard/google/zork/v...
PS9, Line 24: -
Presumably the fields should not be unsigned since we can have negative values. Probably worth a clean up.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43278
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icce57f9be2732ff79f336daa6c447a30247366cf
Gerrit-Change-Number: 43278
Gerrit-PatchSet: 9
Gerrit-Owner: Peichao Li
peichao.wang@bitland.corp-partner.google.com
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Chris Wang
chris.wang@amd.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: chris wang
Chris.Wang@amd.com
Gerrit-CC: Daniel Kurtz
djkurtz@google.com
Gerrit-Comment-Date: Wed, 05 Aug 2020 15:19:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment