Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38647 )
Change subject: drivers/intel/gma/edid: Use byte swap function
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/38647/1/src/drivers/intel/gma/edid....
File src/drivers/intel/gma/edid.c:
https://review.coreboot.org/c/coreboot/+/38647/1/src/drivers/intel/gma/edid....
PS1, Line 96: edid
Call me cursed, buuut... What if you do a pointer cast and use an u32* here? This would make the byteswap unnecessary.
If the type is char or void, then aliasing to a different type does NOT result in nasal demons (undefined behavior, after which anything could happen like demons coming out of everyone's noses). So, it's an option.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38647
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I818318361a83b2b3f0c6d8637dd3b6917590c836
Gerrit-Change-Number: 38647
Gerrit-PatchSet: 1
Gerrit-Owner: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Wed, 05 Feb 2020 15:19:49 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment