Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42503 )
Change subject: post_code: replace postcode values with their respective defined constants
......................................................................
Patch Set 11:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42503/10/src/southbridge/intel/comm...
File src/southbridge/intel/common/finalize.c:
https://review.coreboot.org/c/coreboot/+/42503/10/src/southbridge/intel/comm...
PS10, Line 3: #include <arch/io.h>
Did you mean post_codes.h? I added console. […]
No, I meant <arch/io.h>, you removed outb() call here. But someone could/should make a decision that <console/console.h> is acceptable indirect include for <console/postcodes.h> indeed.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42503
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If32f43104a829bd1db0d5f5340cc94bf0c717c39
Gerrit-Change-Number: 42503
Gerrit-PatchSet: 11
Gerrit-Owner: Sindhoor Tilak
sindhoor@sin9yt.net
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Frans Hendriks
fhendriks@eltan.com
Gerrit-Reviewer: Huang Jin
huang.jin@intel.com
Gerrit-Reviewer: Lee Leahy
leroy.p.leahy@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Comment-Date: Thu, 09 Jul 2020 11:31:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sindhoor Tilak
sindhoor@sin9yt.net
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-MessageType: comment