Raul Rangel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43011 )
Change subject: mb/google/zork: adjust eSPI virtual irq settings ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43011/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/43011/1//COMMIT_MSG@13 PS1, Line 13: ACPI for P2/S devices are active edge high I'm pretty sure the kernel ignores the ACPI entries. It uses the bus defaults for them which means edge/high.
https://review.coreboot.org/c/coreboot/+/43011/1/src/mainboard/google/zork/v... File src/mainboard/google/zork/variants/baseboard/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43011/1/src/mainboard/google/zork/v... PS1, Line 96: ESPI_VW_IRQ_LEVEL_HIGH I need to re read the PPR and decode the macros. Now sure how it was working with LOW here, and HIGH in the MADT.