Shreesh Chhabbi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48286 )
Change subject: src/soc/intel: Add support for CAR_HAS_SF_MASKS and select for TGL ......................................................................
Patch Set 13:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48286/13/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/car/exit_car.S:
https://review.coreboot.org/c/coreboot/+/48286/13/src/soc/intel/common/block... PS13, Line 99:
Am I just the code to reset IA32_L3_MASK_x ?
Sorry I looked at the "CONFIG(INTEL_CAR_CQOS)" code section for teardown. Under "CONFIG(INTEL_CAR_NEM_ENHANCED)", it is not there. We need to add. I dumped the reset default value for IA32_L3_MASK_x. It is 0xFFF (all ways marked for eviction). I think we need to recalculate the available number of ways here since it could change between the processors. Tim do you have any suggestions to save it when we calculate it in NEM initialization code?