Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47350 )
Change subject: lp4x: Add new memory parts and generate SPDs ......................................................................
Patch Set 2:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... File util/spd_tools/lp4x/global_lp4x_mem_parts.json.txt:
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... PS1, Line 191: 2
Is this correct? Page 3 of the spec attached to the bug shows the part as being a QDP.
As per [1], "Thus, number of diesPerPackage is the number of ZQ balls on the package." As per the part datasheet, there are 2 ZQ pins (ZQ0_A and ZQ0_C), hence 2 dies per package.
[1] https://chromium.googlesource.com/chromiumos/third_party/coreboot/+/a98f80fc..."
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... PS1, Line 203: 4
Is this correct? Page 3 of part spec attached to bug shows this part to be an ODP.
Please check as per the comment above.
https://review.coreboot.org/c/coreboot/+/47350/1/util/spd_tools/lp4x/global_... PS1, Line 215: 2
Is this correct? Page 2 of part spec attached to bug shows this part to be a QDP.
Please check as per the comment above.