20 Sep
2022
20 Sep
'22
10:18 p.m.
Attention is currently required from: Sean Rhodes, Nico Huber, Furquan Shaikh, Marshall Dawson, Arthur Heymans, Kyösti Mälkki.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48156 )
Change subject: arch/x86: Only use .bss from car.ld when running XIP ......................................................................
Patch Set 8:
(1 comment)
File src/include/rules.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-159061): https://review.coreboot.org/c/coreboot/+/48156/comment/3665ef59_f61b8e3c PS8, Line 279: #define ENV_SEPARATE_BSS (ENV_CACHE_AS_RAM && (ENV_BOOTBLOCK || !CONFIG(NO_XIP_EARLY_STAGES))) line length of 101 exceeds 96 columns
--
To view, visit https://review.coreboot.org/c/coreboot/+/48156
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cf51f943dde5f642d75ba4c5d3be520dc56370a
Gerrit-Change-Number: 48156
Gerrit-PatchSet: 8
Gerrit-Owner: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Sean Rhodes sean@starlabs.systems
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-CC: Nico Huber nico.h@gmx.de
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Sean Rhodes sean@starlabs.systems
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh furquan.m.shaikh@gmail.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Arthur Heymans arthur@aheymans.xyz
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Comment-Date: Tue, 20 Sep 2022 20:18:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment