Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40001 )
Change subject: mb/google/deltaur: Support to Enable GbE on variant
......................................................................
Patch Set 6:
(2 comments)
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau...
File src/mainboard/google/deltaur/variants/deltan/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau...
PS6, Line 7:
nit: blank line before this
https://review.coreboot.org/c/coreboot/+/40001/6/src/mainboard/google/deltau...
PS6, Line 8: 0x15E1/0x15E2/0x15FC
Are these PCI IDs?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40001
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1c36b132546049e3e775585c41164072f4ece73e
Gerrit-Change-Number: 40001
Gerrit-PatchSet: 6
Gerrit-Owner: Varun Joshi
varun.joshi@intel.com
Gerrit-Reviewer: Bora Guvendik
bora.guvendik@intel.com
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan.m.shaikh@gmail.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Varun Joshi
varun.joshi@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Selma Bensaid
selma.bensaid@intel.corp-partner.google.com
Gerrit-Comment-Date: Fri, 03 Apr 2020 21:17:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment