Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42433 )
Change subject: amd/mandolin: unbreak SeaBIOS VBIOS support ......................................................................
Patch Set 6: Code-Review+1
(4 comments)
https://review.coreboot.org/c/coreboot/+/42433/6//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42433/6//COMMIT_MSG@10 PS6, Line 10: change changed
https://review.coreboot.org/c/coreboot/+/42433/6//COMMIT_MSG@11 PS6, Line 11: SeaBIOS Upstream SeaBIOS, right?
https://review.coreboot.org/c/coreboot/+/42433/6//COMMIT_MSG@16 PS6, Line 16: This is a workaround and not a clean solution, but avoids breakage. Please add a blank line above to separate the paragraphs.
https://review.coreboot.org/c/coreboot/+/42433/6//COMMIT_MSG@18 PS6, Line 18: reverted after a proper fix is implemented. Don’t you have commits in Chromium OS’ SeaBIOS repository to work with this? Maybe mention that?