Vinod Polimera has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39613 )
Change subject: sc7180: Add display 10nm phy & pll programming support ......................................................................
Patch Set 34:
(8 comments)
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 39: static struct dsi_phy_divider_lut_entry_type pll_dividerlut_dphy[] = {
If there's an assumption that pll_post_div must always be a power of 2, that should be documented he […]
Done
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 79: uint32_t escape_freq;
unused?
Done
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 622: for (i = 0; i < 4; i++) {
I think you can replace this loop with just log2(pll_cfg->pll_post_div)?
Done
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 739: while (i < ARRAY_SIZE(clks)) {
nit: This should really use for, not while.
Done
https://review.coreboot.org/c/coreboot/+/39613/33/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy.c:
https://review.coreboot.org/c/coreboot/+/39613/33/src/soc/qualcomm/sc7180/di... PS33, Line 606: vco_freq_hz = pll_output_freq_hz * pll_post_div;
Why are you calculating this when the caller only checks the result for 0? Might as well leave out t […]
Done
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... File src/soc/qualcomm/sc7180/display/dsi_phy_pll.c:
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 21: u32 pll_lockdet_rate;
unused?
Done
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 93: regs->pll_prop_gain_rate = 12;
Where is this used?
it should be used here : dsi_pll_config_hzindep_reg(). Updated
https://review.coreboot.org/c/coreboot/+/39613/32/src/soc/qualcomm/sc7180/di... PS32, Line 132: 0x08
Should this maybe not be hardcoded?
Done