Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43760 )
Change subject: mb/clevo/kbl-u: Add Clevo N240BU as variant ......................................................................
Patch Set 14:
(4 comments)
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/Kconfig:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 3: if BOARD_CLEVO_N13xWU || BOARD_CLEVO_N240BU
let's go for a baseboard approch, because this will get way too long. […]
"baseboard approach" basically means using a new Kconfig symbol that is selected by both variants.
Step 1: Move this if-clause after what currently is `BOARD_SPECIFIC_OPTIONS`
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 5: BOARD_SPECIFIC_OPTIONS Step 2: Replace this with, e.g., `BOARD_CLEVO_KBL_U_SERIES`
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 6: def_bool y Step 3: Make the new symbol default to n
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... File src/mainboard/clevo/kbl-u/variants/n240bu/include/gpio_table.h:
https://review.coreboot.org/c/coreboot/+/43760/14/src/mainboard/clevo/kbl-u/... PS14, Line 31: // PIRQA# There's a G-sensor there, maybe that's why you're having problems with IRQ11