Attention is currently required from: Furquan Shaikh, Tim Wawrzynczak, Subrata Banik, Patrick Rudolph.
Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/52194 )
Change subject: soc/intel/alderlake: revert renaming of CONFIG_MAX_PCIE_CLOCKS
......................................................................
Patch Set 3:
(1 comment)
File src/soc/intel/alderlake/Kconfig:
https://review.coreboot.org/c/coreboot/+/52194/comment/1afdb855_d8434573
PS3, Line 173: MAX_PCIE_CLOCK_SRC
What do you think, Rizwan?
yes, it is a better name. Will need change in all SoC.
Also, since this is just a Kconfig change I am hoping that we don't have to validate the change on all SoC platforms.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/52194
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I747c94331b68c4ec0b6b5a04149856a4bb384829
Gerrit-Change-Number: 52194
Gerrit-PatchSet: 3
Gerrit-Owner: Rizwan Qureshi
rizwan.qureshi@intel.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Subrata Banik
subrata.banik@intel.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Wed, 14 Apr 2021 05:39:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-MessageType: comment