Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47835 )
Change subject: mb/clevo/cml-u: Get rid of cnl_configure_pads() ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/47835/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/47835/1//COMMIT_MSG@7 PS1, Line 7: mb/clevo/cml-u: Get rid of cnl_configure_pads()
describe that the mainboard device driver model is used now
Done
https://review.coreboot.org/c/coreboot/+/47835/1//COMMIT_MSG@8 PS1, Line 8:
was this tested?
Done
https://review.coreboot.org/c/coreboot/+/47835/1/src/mainboard/clevo/cml-u/r... File src/mainboard/clevo/cml-u/ramstage.c:
https://review.coreboot.org/c/coreboot/+/47835/1/src/mainboard/clevo/cml-u/r... PS1, Line 12: .init = init_mainboard,
not sure if we should used .dev_enable or . […]
.init seems reasonable and most other mainboards are using this too.