Hello Lean Sheng Tan,
I'd like you to do a code review. Please visit
https://review.coreboot.org/c/coreboot/+/34209
to review the following change.
Change subject: pci_ids: Drop a block of unused, redundant definitions ......................................................................
pci_ids: Drop a block of unused, redundant definitions
These didn't align with the usual naming conventions and contained some errors beside.
Change-Id: I45033d4cb998a85fc0bec00c54e207226f42de4e Signed-off-by: Nico Huber nico.huber@secunet.com --- M src/include/device/pci_ids.h 1 file changed, 0 insertions(+), 11 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/09/34209/1
diff --git a/src/include/device/pci_ids.h b/src/include/device/pci_ids.h index 35c457a..49a890f 100644 --- a/src/include/device/pci_ids.h +++ b/src/include/device/pci_ids.h @@ -3194,17 +3194,6 @@ /* Intel EMMC device Ids */ #define PCI_DEVICE_ID_INTEL_SKL_EMMC 0x9d2b
-/* Intel PCH Ids */ -#define PCH_CNL_LP_M_SUPER 0x9d80 -#define PCH_CNL_LP_M_SUPER_UNLOCK 0x9d81 -#define PCH_CNL_LP_M_SUPER_LOCK 0x9d82 -#define PCH_CNL_LP_Y_PREMIUM 0x9d83 -#define PCH_CNL_LP_U_PREMIUM 0x9d84 -#define PCH_CNL_LP_U_BASE 0x9d85 -#define PCH_CNL_H_DT_SUPER 0xa280 -#define PCH_CNP_H_MOBILE_Q370 0xa306 -#define PCH_CNP_H_MOBILE_QM370 0xa30c - /* Intel WIFI Ids */ #define PCI_DEVICE_ID_1000_SERIES_WIFI 0x0084 #define PCI_DEVICE_ID_6005_SERIES_WIFI 0x0085