Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34913 )
Change subject: rules: Add ability to disable ENV_CACHE_AS_RAM ......................................................................
Patch Set 2:
(1 comment)
Kyösti, you convinced me on the name. I've squashed the feature into https://review.coreboot.org/c/coreboot/+/32414 and called it "x86: Introduce RESET_VECTOR_IN_DRAM option".
Will abandon this change.
https://review.coreboot.org/c/coreboot/+/34913/2/src/include/rules.h File src/include/rules.h:
https://review.coreboot.org/c/coreboot/+/34913/2/src/include/rules.h@287 PS2, Line 287: #define ENV_CACHE_AS_RAM (CONFIG(ARCH_X86) && !CONFIG(NO_ENV_CACHE_AS_RAM))
... this RESET_VECTOR_IN_DRAM would also conditionalise uses of x86/car.ld in x86/memlayout.ld.
I agree, however that causes a new problem -- not insurmountable but I'm still trying minimize changes outside the picasso directory. We're relying on the fsp2_0 driver that uses the symbols _car_relocatable_data_end and _car_region_end for what we need.
Looks like preram_symbols_available() in symbols.h needs a fix too.
Hmm, I overlooked that. However, since I need to keep them in my hybrid romstage for FSP anyway, I think that should stay as-is. It looks like vboot/common is the only place where that's used currently. The google implementation of vboot will run on the PSP and not the x86.