Attention is currently required from: Nico Huber, Eugene Myers, Benjamin Doron, Angel Pons, Michael Niewöhner. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35523 )
Change subject: mb/acer: Add Acer Aspire VN7-572G ......................................................................
Patch Set 188:
(11 comments)
File src/mainboard/acer/aspire_vn7_572g/bootblock.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/0ea95c32_029c2ea2 PS188, Line 45: if (data_buffer <= (2017 / ADC_3V_10BIT_GRANULARITY_MAX)) { braces {} are not necessary for any arm of this statement
File src/mainboard/acer/aspire_vn7_572g/die.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/f610ee51_d68fd098 PS188, Line 9: if (ENV_POSTCAR) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/mainboard.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/c6d47eb2_a247017b PS188, Line 29: if (!nhlt) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/2277147c_bd5f940e PS188, Line 37: if (nhlt_soc_add_dmic_array(nhlt, 1) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/83b8b502_3f5f2d3f PS188, Line 42: if (nhlt_soc_add_dmic_array(nhlt, 2) != 0) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/3283ed68_cf4e8653 PS188, Line 48: if (end_addr != start_addr) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/0b8f500f_89a3ef6b PS188, Line 61: if (CONFIG(INCLUDE_NHLT_BLOBS)) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/f871b223_f9d3d43d PS188, Line 98: if (dat & 1) { braces {} are not necessary for single statement blocks
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/4026fe87_c4f2f382 PS188, Line 122: if (!(out_data & 2)) { braces {} are not necessary for single statement blocks
File src/mainboard/acer/aspire_vn7_572g/romstage.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/f470e12d_e4506bc7 PS188, Line 11: FSP_M_CONFIG *const mem_cfg = &mupd->FspmConfig; need consistent spacing around '*' (ctx:WxV)
File src/mainboard/acer/aspire_vn7_572g/smihandler.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-132514): https://review.coreboot.org/c/coreboot/+/35523/comment/b08f0f1a_56d7cbf4 PS188, Line 159: if (gnvs) { braces {} are not necessary for single statement blocks