Hung-Te Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35463 )
Change subject: device/mmio.h: Add bit field helpers
......................................................................
Patch Set 13:
Patch Set 13:
Hmm, why is the API mixing host endianness with little-endian
in the SET case? Is that intentional?
I think it's just because we didn't have a clrsetbits() primitive that works directly on host endianness, and we don't have a big-endian architecture anyway. It's meant to be host endianness.
Right. If there was clrsetbits32 I'd definitely use them. Julius and I had discussion on this and the conclusion is there's no active platform using bigendian today in coreboot (the only exception was MIPS, which was going to be dropped) so we can make the change.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35463
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I8a1b17142f7a7dc6c441b0b1ee67d60d73ec8cc8
Gerrit-Change-Number: 35463
Gerrit-PatchSet: 13
Gerrit-Owner: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 27 Nov 2019 02:09:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment