Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43299 )
Change subject: soc/amd/picasso: Add controls for SMT and downcoring ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43299/1/src/soc/amd/picasso/chip.h File src/soc/amd/picasso/chip.h:
https://review.coreboot.org/c/coreboot/+/43299/1/src/soc/amd/picasso/chip.h@... PS1, Line 101: downcore_mode Add a comment that this uses values from enum downcore modes? Or probably just use:
enum { DOWNCORE_AUTO = 0, DOWNCORE_1 = 1, /* Run with single core */ DOWNCORE_2 = 3, /* Run with two cores */ DOWNCORE_3 = 4, /* Run with three cores */ } downcore_mode;
https://review.coreboot.org/c/coreboot/+/43299/1/src/soc/amd/picasso/chip.h@... PS1, Line 102: smt_disable From the name, I am guessing this just takes 0/1?