Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36512 )
Change subject: mb/g/drallion: Override smbios enclosure type for drallion ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/36512/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/36512/3/src/mainboard/google/dralli... PS3, Line 35:
nit: I'd drop the newline here. […]
Done
https://review.coreboot.org/c/coreboot/+/36512/3/src/mainboard/google/dralli... File src/mainboard/google/drallion/variants/drallion/smbios.c:
https://review.coreboot.org/c/coreboot/+/36512/3/src/mainboard/google/dralli... PS3, Line 22: if (gpio_get(SENSOR_DET_360) == 0)
how about return gpio_get(SENSOR_DET_360) :SMBIOS_ENCLOSURE_LAPTOP ?SMBIOS_ENCLOSURE_CONVERTIBLE
Done