build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39868 )
Change subject: mb/google/deltaur: Return SKU ID info ......................................................................
Patch Set 1:
(36 comments)
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltan/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 23: int id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 23: int id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 24: const char *name; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 24: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 28: /* Deltan 360 - invalid configuration */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 29: { .id = -1, .name = "sku_invalid" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 29: { .id = -1, .name = "sku_invalid" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 30: /* Deltan */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 31: { .id = 1, .name = "sku1" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 31: { .id = 1, .name = "sku1" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 32: /* Deltan 360 signed - invalid configuration */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 33: { .id = -1, .name = "sku_invalid" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 33: { .id = -1, .name = "sku_invalid" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 34: /* Deltan signed */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 35: { .id = 2, .name = "sku2" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 35: { .id = 2, .name = "sku2" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 42: return gpio_get(SENSOR_DET_360) == 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 42: return gpio_get(SENSOR_DET_360) == 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... File src/mainboard/google/deltaur/variants/deltaur/include/variant/variant.h:
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 23: int id; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 23: int id; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 24: const char *name; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 24: const char *name; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 28: /* Deltaur 360 */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 29: { .id = 3, .name = "sku3" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 29: { .id = 3, .name = "sku3" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 30: /* Deltaur */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 31: { .id = 4, .name = "sku4" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 31: { .id = 4, .name = "sku4" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 32: /* Deltaur 360 signed */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 33: { .id = 5, .name = "sku5" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 33: { .id = 5, .name = "sku5" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 34: /* Deltaur signed */ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 35: { .id = 6, .name = "sku6" }, code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 35: { .id = 6, .name = "sku6" }, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 41: return gpio_get(SENSOR_DET_360) == 0; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/39868/1/src/mainboard/google/deltau... PS1, Line 41: return gpio_get(SENSOR_DET_360) == 0; please, no spaces at the start of a line