Attention is currently required from: Filip Brozovic, Matt DeVillier, Sean Rhodes.
Angel Pons has posted comments on this change by Filip Brozovic. ( https://review.coreboot.org/c/coreboot/+/86039?usp=email )
Change subject: CFR: Add min/max/step values and hex display flag for number options
......................................................................
Patch Set 3:
(1 comment)
File src/commonlib/include/commonlib/cfr.h:
https://review.coreboot.org/c/coreboot/+/86039/comment/d30c9277_c94ffd82?usp... :
PS2, Line 139: uint32_t min;
: uint32_t max;
: uint32_t step;
Should we add a fixed version number to the header in coreboot, change `lb_cfr_numeric_option` to ad […]
Yes, though the main idea of a CFR version number is to prevent parsing incompatible data structures, i.e. if the version number doesn't match, don't even try to parse anything. It's simpler than supporting multiple versions, and everything should be using the latest version anyway.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86039?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I2e70f1430fb1911f1ad974832f8abfe76f928ac3
Gerrit-Change-Number: 86039
Gerrit-PatchSet: 3
Gerrit-Owner: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Sean Rhodes
sean@starlabs.systems
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Sean Rhodes
sean@starlabs.systems
Gerrit-Attention: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Attention: Filip Brozovic
fbrozovic@gmail.com
Gerrit-Comment-Date: Tue, 21 Jan 2025 08:27:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Filip Brozovic
fbrozovic@gmail.com