Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41889 )
Change subject: dptf: Add support for Fan Performance States
......................................................................
Patch Set 10:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41889/10/src/acpi/acpigen_dptf.c
File src/acpi/acpigen_dptf.c:
https://review.coreboot.org/c/coreboot/+/41889/10/src/acpi/acpigen_dptf.c@33...
PS10, Line 338: _FPS
The fan objects are apparently defined in the ACPI spec itself, so this should in theory go in acpigen.c but given DPTF is the only use it seems fine here too.
https://review.coreboot.org/c/coreboot/+/41889/10/src/acpi/acpigen_dptf.c@34...
PS10, Line 342: percent
the volteer example does seem to have an entry with 0, does that mean it doesn't get written? should this check for non-zero in any field?
register "controls.fan_perf[9]" = "{ 0, 0, 0, 50, }"
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41889
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5591eb527f496d0c4c613352d2a87625d47d9273
Gerrit-Change-Number: 41889
Gerrit-PatchSet: 10
Gerrit-Owner: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Sumeet R Pawnikar
sumeet.r.pawnikar@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 22 Jun 2020 22:04:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment