Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36569 )
Change subject: soc/intel/skylake: add soc implementation for ETR address API ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/36569/1/src/soc/intel/skylake/pmuti... File src/soc/intel/skylake/pmutil.c:
https://review.coreboot.org/c/coreboot/+/36569/1/src/soc/intel/skylake/pmuti... PS1, Line 178: return (uintptr_t) &pcicfg(PCH_DEVFN_PMC)->reg32[ETR / sizeof(uint32_t)]; does not work as expected, yet