Brandon Breitenstein has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40245 )
Change subject: mainboard/volteer: Update Aux settings for Port 0
......................................................................
Patch Set 3:
Patch Set 3:
thanks for the pointer to the doc.
the doc describes a 2nd required configuration step
for AUX DC biasing:
tell the IOM which GPIOs are used for the type-C
pull{up,down} function for a particular port.
where do we configure the SoC to use GPP_E10 and GPP_E13 for port 0?
i'm sorry, but i'm not following how that's happening.
wonkyu also mentioned this needs to happen in his comment.
The IomTypeCPortPadCfg UPD takes care of this in FSP if you take a look at the file I pointed out it is also configuring IOM to use the GPIOs as pull up and pull down
--
To view, visit
https://review.coreboot.org/c/coreboot/+/40245
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic81adc24d10322cc305bf0fa4c38514468ea0942
Gerrit-Change-Number: 40245
Gerrit-PatchSet: 3
Gerrit-Owner: Brandon Breitenstein
brandon.breitenstein@intel.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Wonkyu Kim
wonkyu.kim@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 09 Apr 2020 17:25:31 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment