hsin-hsiung wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45398 )
Change subject: soc/mediatek/mt8192: add pmif driver ......................................................................
Patch Set 28:
(2 comments)
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... File src/soc/mediatek/mt8192/pmif_spi.c:
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... PS7, Line 99:
Print out as a debug message, how long it took?
According to the log, it spends 1 us. log: [reset_spislv] 1 get_us_since_boot 0x1 us [reset_spislv] 2 get_us_since_boot 0x2 us code: printk(BIOS_ERR, "[%s] 1 get_us_since_boot %#x us\n", __func__, get_us_since_boot()); /* Wait for PMIC SPI Master to be idle */ if (check_idle(&mtk_pmicspi_mst->other_busy_sta_0, SPIMST_STA)) { printk(BIOS_ERR, "[%s] spi master busy, timeout\n", __func__); return E_TIMEOUT; } printk(BIOS_ERR, "[%s] 2 get_us_since_boot %#x us\n", __func__, get_us_since_boot());
https://review.coreboot.org/c/coreboot/+/45398/7/src/soc/mediatek/mt8192/pmi... PS7, Line 171: };
- So they are all random numbers? […]
After confirming with DE, they are random numbers in order to verify the read-back data.