Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38858 )
Change subject: security/tpm: Include mrc.bin in CRTM if present
......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38858/1/src/lib/cbfs.c
File src/lib/cbfs.c:
https://review.coreboot.org/c/coreboot/+/38858/1/src/lib/cbfs.c@61
PS1, Line 61: if (fmap_locate_area_as_rdev("COREBOOT", &rdev))
It is originally done by cbfs_locate_file_in_region(), whose behavior I just mirrored here.
Looks good to me. We just hook cbfs_locate afaik
https://review.coreboot.org/c/coreboot/+/38858/5/src/security/tpm/tspi/crtm....
File src/security/tpm/tspi/crtm.c:
https://review.coreboot.org/c/coreboot/+/38858/5/src/security/tpm/tspi/crtm....
PS5, Line 206: /*
Ack
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38858
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib4c3cf47b919864056baf725001ca8a4aaafa110
Gerrit-Change-Number: 38858
Gerrit-PatchSet: 5
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 25 Feb 2020 12:39:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Comment-In-Reply-To: Philipp Deppenwiese
zaolin.daisuki@gmail.com
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Gerrit-MessageType: comment