Marshall Dawson has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34561 )
Change subject: Documentation/soc/amd: Add family 15h ......................................................................
Patch Set 5:
(13 comments)
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG@7 PS5, Line 7: f cap F. Also one below.
https://review.coreboot.org/c/coreboot/+/34561/5//COMMIT_MSG@9 PS5, Line 9: Create documentation for AMD family 15h, and in particular to models for Please make this statement jive with cpu/amd/family_10-family_16h, family15th (and Richland) and pi/00630F01 (a.k.a. Bald Eagle and Kaveri)
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... File Documentation/soc/amd/family15h.md:
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 5: Family 15h is available in several models with different numbers of cores : and some other small variations, This sounds like a marketing one-page. Is there any product that does not come in different numbers of cores and other variations?
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 6: attend a broad spectrum check your wording
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 7: micro architecture one word
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 9: use separate maybe "use a separate"
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 12: , which all [Family 17h](family17h.md) : will also use. I would leave Family 17h and future tense "will use" out of this document.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 19: PSP It feels really out of place to read about the PSP here! Why is it needed for an introduction to Family 15h?
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 29: the binary PI release The reader doesn't yet know what a binaryPI release is.
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 29: coreboo sp
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 34: >In particular, Why blockquote here? Also, I'm not sure that discussing coreboot's GPIO library adds much to the Family 15h discussion, so why is this here at all?
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 43: Control Controller
https://review.coreboot.org/c/coreboot/+/34561/5/Documentation/soc/amd/famil... PS5, Line 45: References Models 00h-0Fh Models 10h-1Fh Models 30h-3Fh