13 comments:
cap F. Also one below.
Patch Set #5, Line 9: Create documentation for AMD family 15h, and in particular to models for
Please make this statement jive with cpu/amd/family_10-family_16h, family15th (and Richland) and pi/00630F01 (a.k.a. Bald Eagle and Kaveri)
File Documentation/soc/amd/family15h.md:
Family 15h is available in several models with different numbers of cores
and some other small variations,
This sounds like a marketing one-page. Is there any product that does not come in different numbers of cores and other variations?
Patch Set #5, Line 6: attend a broad spectrum
check your wording
Patch Set #5, Line 7: micro architecture
one word
Patch Set #5, Line 9: use separate
maybe "use a separate"
, which all [Family 17h](family17h.md)
will also use.
I would leave Family 17h and future tense "will use" out of this document.
It feels really out of place to read about the PSP here! Why is it needed for an introduction to Family 15h?
Patch Set #5, Line 29: the binary PI release
The reader doesn't yet know what a binaryPI release is.
Patch Set #5, Line 29: coreboo
sp
Patch Set #5, Line 34: >In particular,
Why blockquote here? Also, I'm not sure that discussing coreboot's GPIO library adds much to the Family 15h discussion, so why is this here at all?
Patch Set #5, Line 43: Control
Controller
Patch Set #5, Line 45: References
Models 00h-0Fh
Models 10h-1Fh
Models 30h-3Fh
To view, visit change 34561. To unsubscribe, or for help writing mail filters, visit settings.