[coreboot-gerrit] [M] Change in coreboot[master]: soc/intel/{device, common}: Add core_type member to 'struct apic_path'

[Arthur Heymans (Code Review)]

Attention is currently required from: Tarun Tuli, Subrata Banik, Sridhar Siricilla, Sukumar Ghorai, Elyes Haouas.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72131 )

Change subject: soc/intel/{device, common}: Add core_type member to 'struct apic_path'
......................................................................

Patch Set 8:

(1 comment)

File src/soc/intel/common/block/acpi/cpu_hybrid.c:

https://review.coreboot.org/c/coreboot/+/72131/comment/28b82122_a67280a7 
PS8, Line 100: struct device *dev;
             : 	uint32_t lapic_id = lapicid();
             : 
             : 	/* Determine struct device of CPU having apic_id */
             : 	for (dev = get_cpu_bus_first_child(); dev; dev = dev->sibling) {
             : 		if (lapic_id == dev->path.apic.apic_id)
             : 			break;
             : 	}
> cpu_info can't be referenced again in acpi_set_hybrid_cpu_apicid_order() which get executed in non MP context. so, struct device list has to be traversed here to update the core_type!

You don't call this function in acpi_set_hybrid_cpu_apicid_order() so what is the problem?