Rizwan Qureshi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/37947 )
Change subject: ec/google/chromeec: ignore LIMIT_POWER based on command code in response ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c File src/ec/google/chromeec/ec.c:
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 766: printk(BIOS_INFO, "PARAM_LIMIT_POWER not supported by EC.\n");
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 766: printk(BIOS_INFO, "PARAM_LIMIT_POWER not supported by EC.\n");
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 767: *limit_power = 0;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 767: *limit_power = 0;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 768: return 0;
code indent should use tabs where possible
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 768: return 0;
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 769: } else if (rv != 0) {
please, no spaces at the start of a line
Done
https://review.coreboot.org/c/coreboot/+/37947/1/src/ec/google/chromeec/ec.c... PS1, Line 769: } else if (rv != 0) {
code indent should use tabs where possible
Done