Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41489 )
Change subject: src: Remove unused '#include <cpu/x86/lapic.h>'
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/41489/5/src/soc/intel/braswell/nort...
File src/soc/intel/braswell/northcluster.c:
https://review.coreboot.org/c/coreboot/+/41489/5/src/soc/intel/braswell/nort...
PS5, Line 9: #include <cpu/x86/lapic_def.h>
Um... Please mention that.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/41489
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I71cff43d53660dc1e5a760ac3034bcf75f93c6e7
Gerrit-Change-Number: 41489
Gerrit-PatchSet: 5
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Jonathan Zhang
jonzhang@fb.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Wed, 20 May 2020 19:30:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment