[coreboot-gerrit] Change in coreboot[master]: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig

[Subrata Banik (Code Review)]

Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33738 )

Change subject: soc/intel/icelake: Add ENABLE_DISPLAY_OVER_EXT_PCIE_GFX kconfig
......................................................................

Patch Set 12:

(1 comment)

https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon... 
File src/soc/intel/icelake/Kconfig:

https://review.coreboot.org/c/coreboot/+/33738/11/src/soc/intel/icelake/Kcon... 
PS11, Line 210: 	select ALWAYS_LOAD_OPROM
> > Just to check if this is a bug in Gerrit, I'm removing the "Resolved" flag.
>
> Hmmm, this worked. Subrata, did you intentionally mark this as "Resolved"
> while we are discussing it?

I don't select that. not sure why everytime its been "Done".
> ALWAYS_LOAD_OPROM is only needed if you wish to load the OpRom even if it
> *won't* be executed.

yes.

The OS can do this by itself for cards that have an actual
> ROM. The VBT is an Intel concept. Intel's IGD does not have a physical ROM,
> so the VBT/VBIOS has to be loaded from CBFS (what the OS drivers usually
> can't do).

you are right. Always execute should be a problem but not load i believe