[coreboot-gerrit] Change in ...coreboot[master]: superio/nuvoton/nct6791d: Add symbol to select COM port

[Felix Held (Code Review)]

Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33640 )

Change subject: superio/nuvoton/nct6791d: Add symbol to select COM port
......................................................................

Patch Set 1:

(1 comment)

https://review.coreboot.org/#/c/33640/1/src/superio/nuvoton/common/early_ser... 
File src/superio/nuvoton/common/early_serial.c:

https://review.coreboot.org/#/c/33640/1/src/superio/nuvoton/common/early_ser... 
PS1, Line 74: 		pnp_write_config(dev, 0x2a, 0x00);
> I thought so, but has anybody initialized the superio at such an early stage? the other bits aren't  […]

yeah, it probably shouldn't matter too much here. If I saw that correctly, compared to the default values also only the bits related to the serial port get changed, so it should be ok in the current state.