Piotr Kleinschmidt has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42097 )
Change subject: mb/pcengines/apu2/mptable.c: fix invalid MP table and IRQ table ......................................................................
Patch Set 5:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42097/4/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mainboard.c:
https://review.coreboot.org/c/coreboot/+/42097/4/src/mainboard/pcengines/apu... PS4, Line 73: [0x30] = 0x12,0x1F,0x12,0x1F,0x12,0x1F,0x1F,0x00,
One more capital letter to move to CB:42388
fixed in CB:42388
https://review.coreboot.org/c/coreboot/+/42097/4/src/mainboard/pcengines/apu... File src/mainboard/pcengines/apu2/mptable.c:
https://review.coreboot.org/c/coreboot/+/42097/4/src/mainboard/pcengines/apu... PS4, Line 77: PCI_INT(0x0, 0x12, 0x0, intr_data_ptr[PIRQ_OHCI1]); : PCI_INT(0x0, 0x13, 0x0, intr_data_ptr[PIRQ_OHCI2]); : PCI_INT(0x0, 0x16, 0x0, intr_data_ptr[PIRQ_OHCI3]); : PCI_INT(0x0, 0x10, 0x0, intr_data_ptr[PIRQ_OHCI3]);
Why we still use PIRQ_OHCIn?
I have deleted any references to PIRQ_OHCIn.