Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36840 )
Change subject: soc/intel/skylake: Clean up report_cpu_info() function
......................................................................
Patch Set 2: Code-Review-2
(2 comments)
out of bound array access...
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb...
File src/soc/intel/skylake/bootblock/report_platform.c:
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb...
PS2, Line 170: "Platform info not available"
fill_processor_name always overwrites this.
https://review.coreboot.org/c/coreboot/+/36840/2/src/soc/intel/skylake/bootb...
PS2, Line 177: fill_processor_name(cpu_name);
You need to have at least a 49 (3 * 12 + 4 + 1) char array size.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/36840
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Idf7b04edc3fce147f7856591ce7e5a0cd05f43fe
Gerrit-Change-Number: 36840
Gerrit-PatchSet: 2
Gerrit-Owner: Usha P
usha.p@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Usha P
usha.p@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 22 Nov 2019 11:04:40 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment