Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32387 )
Change subject: mb/google/octopus/variants/bloog: Add goodix touchscreen support
......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/32387/1/src/mainboard/google/octopus/variant...
File src/mainboard/google/octopus/variants/bloog/overridetree.cb:
https://review.coreboot.org/#/c/32387/1/src/mainboard/google/octopus/variant...
PS1, Line 110: 120
Is that required as per the datasheet?
https://review.coreboot.org/#/c/32387/1/src/mainboard/google/octopus/variant...
PS1, Line 114: register "generic.enable_delay_ms" = "10"
Is that really required? Enable + reset delay seems to be 130ms which will add to resume time.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/32387
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b3b481ca806b6452d67ace5dfe53f12a14ac3be
Gerrit-Change-Number: 32387
Gerrit-PatchSet: 1
Gerrit-Owner: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Tony Huang
tony-huang@quanta.corp-partner.google.com
Gerrit-Reviewer: Wisley Chen
wisley.chen@quanta.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 23 Apr 2019 00:36:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment